Skip to content

feat: Add error messages for partial migration [FC-0107]#2555

Merged
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:chris/FAL-4262-partial-migration
Oct 22, 2025
Merged

feat: Add error messages for partial migration [FC-0107]#2555
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:chris/FAL-4262-partial-migration

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Oct 22, 2025 •
edited
Loading

Description

  • Adds the error messages for partial migrations
  • Which user roles will this change impact? "Course Author".

Supporting information

Testing instructions

  • Create some legacy libraries with large keys, like: library-v1:LibraryOrganizationField_NOSPACES+LibraryCodeField_NOSPACESALLOWED
  • Create some legacy libraries with normal keys
  • Revert the changes of fix: Issue when migrating legacy libraries with large keys [FC-0107] openedx-platform#37520 to test failed migrations
  • Migrate two libraries with large keys and one with a normal key. Verify the error message. Verify that the legacy library with the normal key is migrated.
  • Migrate one library with large key and one with normal key. Verify the error message. Verify that the legacy library with the normal key is migrated.

Other information

Merge ASAP

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 22, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 22, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 22, 2025
@ChrisChV ChrisChV mentioned this pull request Oct 22, 2025
Merged
@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.74%. Comparing base (5ce61fa) to head (39455f8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2555   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files        1218     1218           
  Lines       27299    27313   +14     
  Branches     5983     5988    +5     
=======================================
+ Hits        25865    25879   +14     
  Misses       1376     1376           
  Partials       58       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rpenido
rpenido approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @ChrisChV!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

bradenmacdonald
bradenmacdonald approved these changes Oct 22, 2025
View reviewed changes
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 22, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Oct 22, 2025
@ChrisChV ChrisChV merged commit 76d8b2e into openedx:master Oct 22, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Oct 22, 2025
@ChrisChV ChrisChV deleted the chris/FAL-4262-partial-migration branch October 22, 2025 22:07
Faraz32123 pushed a commit to edx/frontend-app-authoring that referenced this pull request Oct 24, 2025
@ChrisChV
feat: Add error messages for partial migration [FC-0107] (openedx#2555)
a452ee0 
Adds the error messages for partial migrations
Faraz32123 pushed a commit to edx/frontend-app-authoring that referenced this pull request Oct 24, 2025
@ChrisChV
feat: Add error messages for partial migration [FC-0107] (openedx#2555)
837cd73 
Adds the error messages for partial migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

+1 more reviewer

@rpenido rpenido rpenido approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisChV @openedx-webhooks @rpenido @bradenmacdonald @mphilbrick211